Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect relative prop in NavLink for isActive #9453

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

brophdawg11
Copy link
Contributor

Adding unit tests to #9451

Closes #9450

Co-authored-by: Mikaël ANZANO m.anzano@meetic-corp.com

Co-authored-by: Mikaël ANZANO <m.anzano@meetic-corp.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

🦋 Changeset detected

Latest commit: b96a220

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Oct 12, 2022 that may be closed by this pull request
@brophdawg11 brophdawg11 merged commit 35ff025 into dev Oct 17, 2022
@brophdawg11 brophdawg11 deleted the brophdawg11/navlink-relative branch October 17, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NavLink is never active when using relative="path"
4 participants